Move CrateInfo computation after codegen_crate#156243
Open
bjorn3 wants to merge 1 commit intorust-lang:mainfrom
Open
Move CrateInfo computation after codegen_crate#156243bjorn3 wants to merge 1 commit intorust-lang:mainfrom
bjorn3 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
The GCC codegen subtree was changed |
rustbot
added
A-LLVM
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
bjorn3
commented
May 6, 2026
| @@ -1,5 +1,3 @@ | |||
| error: crate `rmeta_meta` required to be available in rlib format, but was not found in this form | |||
Member
Author
There was a problem hiding this comment.
This error was already only emitted for crates that need to be linked or that perform LTO, not when compiling rlibs. There is still a decent error message about missing optimized MIR if MIR of upstream crates is necessary. And if that isn't necessary, this dependency format error will still be shown after codegen.
This comment has been minimized.
This comment has been minimized.
13 tasks
CrateInfo is only necessary during linking and non-local LTO.
mu001999
reviewed
May 7, 2026
Member
|
@rustbot author |
rustbot
added
S-waiting-on-author
bjorn3
added
S-waiting-on-review
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 7, 2026
Move CrateInfo computation after codegen_crate CrateInfo is only necessary during linking and non-local LTO. Part of rust-lang/compiler-team#908
rust-bors Bot
pushed a commit
that referenced
this pull request
May 7, 2026
…uwer Rollup of 5 pull requests Successful merges: - #146273 (lint ImproperCTypes: refactor linting architecture (part 2)) - #156024 (CFI: Fix LTO for `#![no_builtins]` crates with CFI) - #156243 (Move CrateInfo computation after codegen_crate) - #156245 (Move invocation_temp into OutputFilenames) - #156265 (Remove unused `ToStableHashKey` impls.)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 7, 2026
Move CrateInfo computation after codegen_crate CrateInfo is only necessary during linking and non-local LTO. Part of rust-lang/compiler-team#908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CrateInfo is only necessary during linking and non-local LTO.
Part of rust-lang/compiler-team#908